backoffice-bt-credit-notes
Central business logic (as a NuGet package) for creating Business Travel credit notes, plus a job that checks pending credit notes and marks them approved.
Health score
0 to 100 across seven weighted factors; nothing is hidden. Green is 75 and above, amber 50 to 74, red below 50. How scoring works.
Facts
| Languages | csharp |
| Frameworks | TC.Phenix.ApplicationFramework 5.4, TC.MaintainanceTools.SimpleJobs 4.2 |
| Runtimes | .NET 8, .NET Standard 2.0 |
| Tests / CI | some / CI in place |
| Last commit | 2025-06-27 |
| Owner | Owner unknown (mapping to be curated) |
| Domain | Payments and finance (system generated; curate in repo-owners.json to override) |
| Product area | Phenix |
| Hosted | On-prem Deployed to our own machines
|
| Releases | 1 release pipeline(s): \finance\backoffice-bt\backoffice-bt-credit-notes |
| Integration | rest, wcf |
| Source | Open in Azure DevOps |
Risk flags
Each flag links to its glossary definition.
Dependencies in context
Entanglement
kernel Bound into the core by 2 mechanism(s).
- Pinning dependency: mailtemplate-service
- Speaks WCF (client)
Detaches when its pinning dependencies are cut or multi-targeted (mailtemplate-service); and when its WCF surface gains a modern interface or its WCF calls move to one.
Depends on / used by
Migration playbooks
Generated from this repo's assessment data: what is feasible, what blocks it, and the steps in order. Ratings: green means actionable now, amber means sequence other work first, red means blocked, grey means not applicable.
ZDD adoption
Ready with guardrailsClose: the deployment path exists, but specific checks are needed first, typically raising tests, auditing serialized data, or respecting a shared schema with expand and contract. Test coverage is thin; ZDD shifts the safety net onto automation.
- Consumes WCF contract packages: never take a breaking client bump mid-feature, and treat obsolete warnings as migration debt
- Adopt the four-stage discipline from the ZDD engineering standard: pre-deployment compatibility, deployment, feature activation behind a flag, post-release cleanup.
- Raise automated test coverage first: ZDD trades the end-of-sprint manual gate for continuous automated confidence, so the tests are the entry ticket.
- Make every change dual-version safe: backwards-compatible APIs (new major version for breaking wire changes), expand and contract for any schema change, and consumers tolerant of unknown fields.
- Wrap behaviour changes in feature flags so code deploys dark and release becomes a business decision, not a deployment event.
- Route deployments through the Workflow Engine's automated drain, deploy, health-check, return cycle (the path proven by the first automated production run in mid-2026).
- Verify with area-scoped regression rather than the whole-platform cycle, and watch error rates after rollout with automated rollback on alert.
SQL Server exit
Not applicableNo SQL Server dependency is recorded for this repo. Nothing to migrate.
Containerisation
Ready to containeriseModern runtime, no hosted legacy transport: this service can follow the estate's proven container path (Dockerfile, shared pipeline template, ECS via Terraform).
- Add a Dockerfile and make the app read all configuration from environment variables and the secrets manager, never from machine-local files.
- Log to stdout and expose a health check endpoint so ECS can supervise it.
- Adopt the shared ci.yml pipeline template with the container parameters (awsRegion, containerAfterBuild, ecsTerraformRepo), which is exactly how the estate's existing AWS services deploy.
- Define the service in the Terraform repo, deploy to a non-production environment, then shift traffic and disarm the deployment-group release pipeline.
Recommended actions
No specific actions for this repo. It either needs only normal maintenance, or its work is covered by an estate-level action. See the full programme.
Assessment notes
backoffice-bt-credit-notes
Purpose
Contains the central logic for creating Business Travel credit notes, shipped as the TC.BusinessTravel.CreditNote.BusinessLogic NuGet package, and a console job (TC.BusinessTravel.CreditNote.Job) that polls for pending credit notes and self-approves them where rules allow.
Tech stack
C# solution on .NET 8 (job, tests) with the shared business-logic library targeting .NET Standard 2.0 so it can be consumed by older frameworks. Built on internal Travel Counsellors packages: TC.Phenix.ApplicationFramework, TC.Phenix.Services.Client, TC.MaintainanceTools.SimpleJobs, TC.ConnectionBroker.Wcf. LangVersion 12, analysers (Sonar, NetAnalyzers, SecurityCodeScan) enabled via Directory.Build.props.
Deployment
One release pipeline (\finance\backoffice-bt\backoffice-bt-credit-notes) fed by the backoffice-bt-credit-notes CI build; release_count 1. CI is Azure Pipelines YAML (build.yaml) using shared templates from InternalOSS/azure-pipelines-templates, building the job app and publishing the BusinessLogic package.
Dependencies
Internal: consumes contracts/clients from backoffice-documentation-booking (TC.Documentation.Booking.Contract), tc-connectionbroker (WCF connection broker), mailtemplate-service (TC.Mail.Template.ServiceContract), plus Phenix services via TC.Phenix.Services.Client and TC.UserAccount.ServiceContract (exact source repos for those packages not confirmed). External: none beyond NuGet tooling.
Data stores
No direct connection strings in the repo; data access goes through internal service clients (Phenix services / connection broker). Environment appsettings files are empty placeholders (config injected at release time).
Integration points
Calls internal TC services over REST (Phenix services client, exceptions web API client) and WCF (TC.ConnectionBroker.Wcf). No message-bus usage found.
Code health
xUnit test project with focused business-rule tests (credit note state, approval rules) plus Moq and coverlet coverage. YAML CI on master/release branches. Last commit 2025-06-27 — actively maintained within the last year.
Modernisation risks
Low risk: modern .NET 8 runtime and current tooling. Residual concerns are the .NET Standard 2.0 target (kept for legacy consumers), WCF client dependency, and coupling to internal framework packages whose upgrade cadence it must follow.