Platform Evolution
Assessment run-2026-07-27-1 · 213 of 213 repos assessed
Repos / phenix-selling-api

phenix-selling-api

.NET 8 API exposing selling-time calculations for Phenix — deposit amounts, agent/company markups and tax quotes — over the shared Phenix data and services.

74 · amberlowkernelOn-premZDD: ready with guardrailsapi

Health score

74

0 to 100 across seven weighted factors; nothing is hidden. Green is 75 and above, amber 50 to 74, red below 50. How scoring works.


Runtime currency / 25
25
Runs on supported modern .NET
Legacy transport / 15
6
Calls at least one legacy WCF endpoint
Test posture / 15
8
Some tests, coverage is thin
Security hygiene / 15
15
No credentials found in source
Dangerous coupling / 15
8
shares a core database (sqlserver:Phenix)
Activity / 10
8
Last commit six to twelve months ago
Deployment hygiene / 5
5
CI in place
Health over time
2026-07-24 (run-2026-07-24-1): 742026-07-27 (run-2026-07-27-1): 74
No change since 2026-07-24 (74 to 74).

Facts

Languagescsharp
FrameworksASP.NET Core 8, MediatR, Dapper, FluentValidation
Runtimes.NET 8
Tests / CIsome / CI in place
Last commit2025-10-30
OwnerOwner unknown (mapping to be curated)
DomainSelling and quoting (system generated; curate in repo-owners.json to override)
Product areaPhenix
HostedOn-prem Deployed to our own machines
  • Release "\commercial\phenix-selling-api": QA: deployment-group phase (agents on our own machines)
  • Release "\commercial\phenix-selling-api": Staging: deployment-group phase (agents on our own machines)
  • Release "\commercial\phenix-selling-api": Production: deployment-group phase (agents on our own machines)
  • Release "\commercial\phenix-selling-api": Training: deployment-group phase (agents on our own machines)
  • Release "\commercial\phenix-selling-api": DR: deployment-group phase (agents on our own machines)
Releases1 release pipeline(s): \commercial\phenix-selling-api
Integrationrest, wcf, redis
SourceOpen in Azure DevOps

Risk flags

Each flag links to its glossary definition.

Dependencies in context

Laying out the graph…
greenamberreddata store (square, dashed link)Node size follows fan-in. Click any node to open it.

Entanglement

kernel Bound into the core by 2 mechanism(s).

Detaches when its WCF surface gains a modern interface or its WCF calls move to one; and when the shared database group it belongs to gains an owned API or completes schema separation (sqlserver:Phenix).

Depends on / used by


Data stores
sqlserver:Phenixredis:remote-session

Migration playbooks

Generated from this repo's assessment data: what is feasible, what blocks it, and the steps in order. Ratings: green means actionable now, amber means sequence other work first, red means blocked, grey means not applicable.

ZDD adoption

Ready with guardrails

Close: the deployment path exists, but specific checks are needed first, typically raising tests, auditing serialized data, or respecting a shared schema with expand and contract. Shares sqlserver:Phenix: expand and contract is mandatory for any schema change. Test coverage is thin; ZDD shifts the safety net onto automation.

Blockers
Dependencies and gotchas
  • Consumes WCF contract packages: never take a breaking client bump mid-feature, and treat obsolete warnings as migration debt
  • Shares sqlserver:Phenix with 21 system(s): destructive schema change is prohibited in a single release; expand and contract only
  • Serialized state or messages in flight (Redis or queues): new code must deserialize objects written by the previous version
  • Session is externalised to Redis: keep it that way, and check session object compatibility between versions
Steps
  1. Adopt the four-stage discipline from the ZDD engineering standard: pre-deployment compatibility, deployment, feature activation behind a flag, post-release cleanup.
  2. Raise automated test coverage first: ZDD trades the end-of-sprint manual gate for continuous automated confidence, so the tests are the entry ticket.
  3. Make every change dual-version safe: backwards-compatible APIs (new major version for breaking wire changes), expand and contract for any schema change, and consumers tolerant of unknown fields.
  4. Audit serialized data: anything in Redis, queues or shared caches must deserialize cleanly across adjacent versions.
  5. Wrap behaviour changes in feature flags so code deploys dark and release becomes a business decision, not a deployment event.
  6. Route deployments through the Workflow Engine's automated drain, deploy, health-check, return cycle (the path proven by the first automated production run in mid-2026).
  7. Verify with area-scoped regression rather than the whole-platform cycle, and watch error rates after rollout with automated rollback on alert.

SQL Server exit

Blocked by a shared core database

sqlserver:Phenix is shared, so this system cannot change engine on its own: every sharer moves in convoy. The stage 4 work (named owner, declarative schema, owned API) has to land first; after that, the steps below apply to whatever slice this system ends up owning.

Blockers
Steps
  1. Inventory the schema and query surface of sqlserver:Phenix: tables, stored procedures, triggers, cross-database joins and anything else engine-specific.
  2. Confirm the target: PostgreSQL (relational model; keep transactions and joins, swap the engine).
  3. Data access is not through an ORM, so port the SQL by hand: translate T-SQL constructs, replace stored procedures with application code or target-native equivalents, and add integration tests around the queries that matter first.
  4. Stand up the target alongside SQL Server, backfill with an ETL pass (pgloader or an export/import job), then dual-write or replicate until parity is proven.
  5. Move reads to the target, watch correctness and latency, then cut writes over and keep SQL Server read-only until confidence is earned.
  6. Decommission the SQL Server database and remove the connection strings and firewall paths that pointed at it.

Containerisation

Ready to containerise

Modern runtime, no hosted legacy transport: this service can follow the estate's proven container path (Dockerfile, shared pipeline template, ECS via Terraform).

Steps
  1. Add a Dockerfile and make the app read all configuration from environment variables and the secrets manager, never from machine-local files.
  2. Log to stdout and expose a health check endpoint so ECS can supervise it.
  3. Adopt the shared ci.yml pipeline template with the container parameters (awsRegion, containerAfterBuild, ecsTerraformRepo), which is exactly how the estate's existing AWS services deploy.
  4. Define the service in the Terraform repo, deploy to a non-production environment, then shift traffic and disarm the deployment-group release pipeline.

Recommended actions

No specific actions for this repo. It either needs only normal maintenance, or its work is covered by an estate-level action. See the full programme.

Assessment notes

phenix-selling-api

Purpose

A focused selling-domain API with three endpoint groups — Deposits, Markups and Tax — used at selling time in Phenix. It calculates deposits via TC.Phenix.DepositCalculation strategies, reads markup data from the Phenix database, and proxies tax quotes to the tax service.

Tech stack

Single ASP.NET Core project on .NET 8 (SDK-style, implicit usings), MediatR handlers behind minimal-API endpoint groups, Dapper stored-procedure calls, FluentValidation, Swagger with examples, health checks, and the TC platform stack: full ConnectionBroker suite (Api, Mongo, Redis, Sql, Wcf), TC.Cache with Redis, TC.RemoteSession.Redis, TravelCounsellors.ApiTools.

Deployment

One release pipeline \commercial\phenix-selling-api (release_count 1) from the matching build pipeline, defined by azure-pipelines.yml in the repo. Per-environment appsettings transforms (QA, Training, PreProduction, Live, etc.).

Dependencies

Internal packages: TC.ConnectionBroker 1.19, TC.ExchangeRate.ServiceClient (exchange-rate-service), TC.Phenix.Tax.ServiceContract (tax-service), Phenix.Provider.Domain (phenix-provider), TC.Phenix.Services.Client over WCF, TC.Phenix.DepositCalculation, TravelCounsellors.ApiTools (tc-api-tools). No third-party services.

Data stores

No owned database — Dapper repositories call stored procedures against the shared Phenix SQL Server database via ConnectionBroker (GetDatabaseConnectionString("Phenix")). Redis backs the remote session and cache.

Integration points

Inbound REST (Swagger-documented endpoint groups). Outbound WCF to the legacy Phenix services via TC.Phenix.Services.Client, REST to the tax/exchange-rate services, Redis for session/cache.

Code health

Modern, tidy codebase with stylecop/rulesets and Nerdbank versioning, but only one test class (four StrategyFactory tests) — very thin coverage for the calculation logic it owns. README is the untouched Azure DevOps boilerplate. Last commit 2025-10-30.

Modernisation risks

Low priority: current .NET 8 runtime with YAML CI. Residual risks are coupling to the shared Phenix database and the legacy WCF Phenix services client, both of which tie its fate to the wider Phenix modernisation, plus near-absent test coverage of financial calculations.