Repos / job-close-bookings

job-close-bookings

Console job that flags Phenix bookings as closed after a configurable post-return period (with an open mode to reverse accidental closures), preventing further edits in Phenix.

84 · greenlowloosely attachedOn-premZDD: ready with guardrailsjob

Health score

0 to 100 across seven weighted factors; nothing is hidden. Green is 75 and above, amber 50 to 74, red below 50. How scoring works.

Runtime currency / 25

Runs on supported modern .NET

Legacy transport / 15

Calls at least one legacy WCF endpoint

Test posture / 15

Some tests, coverage is thin

Security hygiene / 15

No credentials found in source

Dangerous coupling / 15

No dangerous coupling detected

Activity / 10

Actively maintained

Deployment hygiene / 5

CI in place

Health over time

No change since 2026-07-24 (84 to 84).

Facts

Languages	csharp
Frameworks	TC.MaintainanceTools.SimpleJobs 6, TC.ConnectionBroker 1.20
Runtimes	.NET 8
Tests / CI	some / CI in place
Last commit	2026-06-04
Owner	Owner unknown (mapping to be curated)
Domain	Bookings and fulfilment (system generated; curate in repo-owners.json to override)
Product area	Phenix
Hosted	On-prem Deployed to our own machines Release "\finance\jobs\job-close-bookings CI": Staging: deployment-group phase (agents on our own machines) Release "\finance\jobs\job-close-bookings CI": Staging: deployment-group phase (agents on our own machines) Release "\finance\jobs\job-close-bookings CI": Production: deployment-group phase (agents on our own machines)
Releases	1 release pipeline(s): \finance\jobs\job-close-bookings CI
Integration	wcf
Source	Open in Azure DevOps

Risk flags

wcf-client manual-run-risk

Each flag links to its glossary definition.

Dependencies in context

View in full graph

No internal dependencies, dependents or shared stores recorded for this repo.

greenamberreddata store (square, dashed link)Node size follows fan-in. Click any node to open it.

Entanglement

loosely attached Bound into the core by 1 mechanism(s).

Speaks WCF (client)

Detaches when its WCF surface gains a modern interface or its WCF calls move to one.

Depends on / used by

Depends on (0)

Nothing internal.

Used by (0)

No internal dependents.

Migration playbooks

Generated from this repo's assessment data: what is feasible, what blocks it, and the steps in order. Ratings: green means actionable now, amber means sequence other work first, red means blocked, grey means not applicable.

ZDD adoption

Ready with guardrails

Close: the deployment path exists, but specific checks are needed first, typically raising tests, auditing serialized data, or respecting a shared schema with expand and contract. Test coverage is thin; ZDD shifts the safety net onto automation.

Dependencies and gotchas

Consumes WCF contract packages: never take a breaking client bump mid-feature, and treat obsolete warnings as migration debt

Steps

Adopt the four-stage discipline from the ZDD engineering standard: pre-deployment compatibility, deployment, feature activation behind a flag, post-release cleanup.
Raise automated test coverage first: ZDD trades the end-of-sprint manual gate for continuous automated confidence, so the tests are the entry ticket.
Make every change dual-version safe: backwards-compatible APIs (new major version for breaking wire changes), expand and contract for any schema change, and consumers tolerant of unknown fields.
Wrap behaviour changes in feature flags so code deploys dark and release becomes a business decision, not a deployment event.
Route deployments through the Workflow Engine's automated drain, deploy, health-check, return cycle (the path proven by the first automated production run in mid-2026).
Verify with area-scoped regression rather than the whole-platform cycle, and watch error rates after rollout with automated rollback on alert.

SQL Server exit

Not applicable

No SQL Server dependency is recorded for this repo. Nothing to migrate.

Containerisation

Ready to containerise

Modern runtime, no hosted legacy transport: this service can follow the estate's proven container path (Dockerfile, shared pipeline template, ECS via Terraform).

Steps

Add a Dockerfile and make the app read all configuration from environment variables and the secrets manager, never from machine-local files.
Log to stdout and expose a health check endpoint so ECS can supervise it.
Adopt the shared ci.yml pipeline template with the container parameters (awsRegion, containerAfterBuild, ecsTerraformRepo), which is exactly how the estate's existing AWS services deploy.
Define the service in the Terraform repo, deploy to a non-production environment, then shift traffic and disarm the deployment-group release pipeline.

Recommended actions

No specific actions for this repo. It either needs only normal maintenance, or its work is covered by an estate-level action. See the full programme.

Assessment notes

job-close-bookings

Purpose

Scheduled/manually-run console job that finds bookings returned from departure beyond a "days to keep open" threshold (business and leisure thresholds, default 366 days) and marks them closed in Phenix. Also supports closing/reopening explicit booking id lists via CLI flags. Closure blocks editing in Phenix and is not easily reversible without a datafix.

Tech stack

C# console app on .NET 8 (net8.0, nullable + implicit usings enabled), single project CloseBookingsJob plus a test project.
Built on the in-house TC.MaintainanceTools.SimpleJobs job framework with AppSettings configuration, TC.ConnectionBroker (incl. WCF flavour) for service connectivity, and TC.Phenix.Services.Client 7.59 for the Phenix booking service.
Docker target OS Linux is declared in the csproj, but no Dockerfile is present in the repo.

Deployment

Included as a prod application with 1 release. Build pipeline job-close-bookings (YAML build.yaml using shared InternalOSS/azure-pipelines-templates, .NET SDK 8.0.x) feeding release pipeline \finance\jobs\job-close-bookings CI.

Dependencies

Internal NuGet packages: TC.Phenix.Services.Client, TC.ConnectionBroker.*, TC.MaintainanceTools.SimpleJobs.*, TC.Exceptions.WebApiClient. The Phenix booking service it calls lives elsewhere in the estate, but the exact hosting repo could not be confirmed from this codebase, so no internal repo dependency is recorded.
Third-party: Scrutor (DI scanning); no external SaaS integrations.

Data stores

None accessed directly; all reads/writes go through the Phenix booking service facade (GetOpenPhenixBookingIdsByReturnedDateRange, InsertClosedSalesOrder, etc.).

Integration points

WCF calls to the Phenix booking service via TC.Phenix.Services.Client.BookingServiceReference and TC.ConnectionBroker.Wcf, with environment selection via --env: argument.

Code health

Small, tidy codebase with unit tests (CloseBookingsJobTests, ArgumentOverridesTests) and YAML CI using shared templates.
Actively maintained: last commit 2026-06-04; README is detailed and current.

Modernisation risks

Depends on a legacy WCF service surface in Phenix; any Phenix booking-service modernisation forces a client change here.
Destructive by design ("cannot be easily undone without a datafix"); safe-guarding relies on operator care with CLI arguments.
Otherwise low risk: modern .NET 8 runtime, tests present, CI in place.