phenix-booking-commission-rate-api
API for getting and storing commission rates against a booking for a team, acting as a middle man between consuming applications and the teams service with a history-tracking database.
Health score
0 to 100 across seven weighted factors; nothing is hidden. Green is 75 and above, amber 50 to 74, red below 50. How scoring works.
Facts
| Languages | csharp, sql |
| Frameworks | ASP.NET Core 8, MediatR 12, Dapper 2 |
| Runtimes | .NET 8 |
| Tests / CI | some / CI in place |
| Last commit | 2025-08-01 |
| Owner | Owner unknown (mapping to be curated) |
| Domain | Payments and finance (system generated; curate in repo-owners.json to override) |
| Product area | Phenix |
| Hosted | On-prem Deployed to our own machines
|
| Releases | 3 release pipeline(s): \finance\commission\booking-commission-rate Database; \finance\commission\phenix-booking-commission-rate-api; \finance\commission\phenix-booking-commission-rate-api - Stealth |
| Integration | rest, redis-streams |
| Source | Open in Azure DevOps |
Dependencies in context
Entanglement
loose No binding mechanisms apply: this system needs no untangling work.
Depends on / used by
Migration playbooks
Generated from this repo's assessment data: what is feasible, what blocks it, and the steps in order. Ratings: green means actionable now, amber means sequence other work first, red means blocked, grey means not applicable.
ZDD adoption
Ready with guardrailsClose: the deployment path exists, but specific checks are needed first, typically raising tests, auditing serialized data, or respecting a shared schema with expand and contract. Test coverage is thin; ZDD shifts the safety net onto automation.
- Serialized state or messages in flight (Redis or queues): new code must deserialize objects written by the previous version
- Adopt the four-stage discipline from the ZDD engineering standard: pre-deployment compatibility, deployment, feature activation behind a flag, post-release cleanup.
- Raise automated test coverage first: ZDD trades the end-of-sprint manual gate for continuous automated confidence, so the tests are the entry ticket.
- Make every change dual-version safe: backwards-compatible APIs (new major version for breaking wire changes), expand and contract for any schema change, and consumers tolerant of unknown fields.
- Audit serialized data: anything in Redis, queues or shared caches must deserialize cleanly across adjacent versions.
- Wrap behaviour changes in feature flags so code deploys dark and release becomes a business decision, not a deployment event.
- Route deployments through the Workflow Engine's automated drain, deploy, health-check, return cycle (the path proven by the first automated production run in mid-2026).
- Verify with area-scoped regression rather than the whole-platform cycle, and watch error rates after rollout with automated rollback on alert.
SQL Server exit
Feasible now (1 owned database)The database is solely owned by this system, so the migration is self-contained. Recommended target: PostgreSQL.
- Inventory the schema and query surface of sqlserver:BookingCommissionRate: tables, stored procedures, triggers, cross-database joins and anything else engine-specific.
- Confirm the target: PostgreSQL (relational model; keep transactions and joins, swap the engine).
- Data access is not through an ORM, so port the SQL by hand: translate T-SQL constructs, replace stored procedures with application code or target-native equivalents, and add integration tests around the queries that matter first.
- Stand up the target alongside SQL Server, backfill with an ETL pass (pgloader or an export/import job), then dual-write or replicate until parity is proven.
- Move reads to the target, watch correctness and latency, then cut writes over and keep SQL Server read-only until confidence is earned.
- Decommission the SQL Server database and remove the connection strings and firewall paths that pointed at it.
Containerisation
Ready to containeriseModern runtime, no hosted legacy transport: this service can follow the estate's proven container path (Dockerfile, shared pipeline template, ECS via Terraform).
- Add a Dockerfile and make the app read all configuration from environment variables and the secrets manager, never from machine-local files.
- Log to stdout and expose a health check endpoint so ECS can supervise it.
- Adopt the shared ci.yml pipeline template with the container parameters (awsRegion, containerAfterBuild, ecsTerraformRepo), which is exactly how the estate's existing AWS services deploy.
- Define the service in the Terraform repo, deploy to a non-production environment, then shift traffic and disarm the deployment-group release pipeline.
Recommended actions
No specific actions for this repo. It either needs only normal maintenance, or its work is covered by an estate-level action. See the full programme.
Assessment notes
phenix-booking-commission-rate-api
Purpose
Stores and retrieves commission rates against a booking for a team. Sits between consuming applications and the teams service; every rate update inserts a new row so history is tracked.
Tech stack
C# on .NET 8, ASP.NET Core Web API with MediatR command/query handlers, Dapper + System.Data.SqlClient for data access, Swashbuckle/NSwag for OpenAPI, PhenixAuth authentication, TC.ConnectionBroker suite and TC.Streams (Redis provider). The database is a SQL Server DACPAC project (db/BookingCommissionRate.sqlproj, Sql120 schema provider).
Deployment
Three release pipelines under \finance\commission\ (API, API Stealth, and a separate Database release) built from two build pipelines (phenix-booking-commission-rate-api and its Database build); release_count 3. CI uses shared azure-pipelines-templates with .NET SDK 8.0.x; the DB build uses the shared build-db.yml template.
Dependencies
Internal: teams-service (via TC.Teams.Contracts and REST calls resolved through ConnectionBroker). Also consumes shared TC platform NuGet packages (ConnectionBroker, Streams, Exceptions, HealthChecks). External: New Relic APM.
Data stores
Owns the BookingCommissionRate SQL Server database (DACPAC-deployed). Request/response logging to MongoDB database bookingCommissionRate_logs; Redis used for TC.Streams eventing.
Integration points
Versioned REST API with Swagger UI; publishes/consumes events over Redis streams (TC.Streams); outbound HTTP to teams-service.
Code health
Two test projects (Common unit tests and API integration tests). CI on shared templates with build + DB pipelines. Last commit 2025-08-01, roughly a year old but on a current runtime.
Modernisation risks
Low: modern .NET 8 stack with its own database. The SSDT sqlproj (Sql120/.NET Framework 4.8.1 tooling) is the main legacy element, and the codebase shares the estate-wide coupling to internal TC.* NuGet packages.