phenix-sales-agent-markup
Single-page ASP.NET MVC site inside Phenix letting a sales agent view and update their default accommodation markup percentage.
Health score
0 to 100 across seven weighted factors; nothing is hidden. Green is 75 and above, amber 50 to 74, red below 50. How scoring works.
Facts
| Languages | csharp |
| Frameworks | ASP.NET MVC 5, Autofac |
| Runtimes | .NET Framework 4.8.1, .NET Framework 4.6.2 |
| Tests / CI | some / CI in place |
| Last commit | 2026-01-13 |
| Owner | Owner unknown (mapping to be curated) |
| Domain | Selling and quoting (system generated; curate in repo-owners.json to override) |
| Product area | Phenix |
| Hosted | On-prem Deployed to our own machines
|
| Releases | 1 release pipeline(s): phenix-sales-agent-markup |
| Integration | rest, wcf |
| Source | Open in Azure DevOps |
Risk flags
Each flag links to its glossary definition.
Dependencies in context
Entanglement
kernel Bound into the core by 3 mechanism(s).
- Pinning dependency: application-framework
- Speaks WCF (client)
- Shares core database sqlserver:Phenix
Detaches when its pinning dependencies are cut or multi-targeted (application-framework); and when its WCF surface gains a modern interface or its WCF calls move to one; and when the shared database group it belongs to gains an owned API or completes schema separation (sqlserver:Phenix).
Depends on / used by
Migration playbooks
Generated from this repo's assessment data: what is feasible, what blocks it, and the steps in order. Ratings: green means actionable now, amber means sequence other work first, red means blocked, grey means not applicable.
ZDD adoption
A long roadTechnically eligible one day, but the blockers are structural: hosted WCF or SOAP contracts that cannot run two versions at once, or heavy legacy coupling. Sequence the modernisation work first. Legacy web front end: session state and framework age make mixed-version fleets risky until state is externalised.
- Consumes WCF contract packages: never take a breaking client bump mid-feature, and treat obsolete warnings as migration debt
- Shares sqlserver:Phenix with 21 system(s): destructive schema change is prohibited in a single release; expand and contract only
- Adopt the four-stage discipline from the ZDD engineering standard: pre-deployment compatibility, deployment, feature activation behind a flag, post-release cleanup.
- Raise automated test coverage first: ZDD trades the end-of-sprint manual gate for continuous automated confidence, so the tests are the entry ticket.
- Make every change dual-version safe: backwards-compatible APIs (new major version for breaking wire changes), expand and contract for any schema change, and consumers tolerant of unknown fields.
- Audit serialized data: anything in Redis, queues or shared caches must deserialize cleanly across adjacent versions.
- Externalise any remaining session state so users can move between nodes mid-session without disruption.
- Wrap behaviour changes in feature flags so code deploys dark and release becomes a business decision, not a deployment event.
- Route deployments through the Workflow Engine's automated drain, deploy, health-check, return cycle (the path proven by the first automated production run in mid-2026).
- Verify with area-scoped regression rather than the whole-platform cycle, and watch error rates after rollout with automated rollback on alert.
SQL Server exit
Blocked by a shared core databasesqlserver:Phenix is shared, so this system cannot change engine on its own: every sharer moves in convoy. The stage 4 work (named owner, declarative schema, owned API) has to land first; after that, the steps below apply to whatever slice this system ends up owning.
- Inventory the schema and query surface of sqlserver:Phenix: tables, stored procedures, triggers, cross-database joins and anything else engine-specific.
- Confirm the target: PostgreSQL (relational model; keep transactions and joins, swap the engine).
- Replatform to modern .NET first (see the recommended actions): current PostgreSQL and MongoDB drivers and EF Core providers target modern .NET, and doing one risky change at a time is cheaper than doing two.
- Data access is not through an ORM, so port the SQL by hand: translate T-SQL constructs, replace stored procedures with application code or target-native equivalents, and add integration tests around the queries that matter first.
- Stand up the target alongside SQL Server, backfill with an ETL pass (pgloader or an export/import job), then dual-write or replicate until parity is proven.
- Move reads to the target, watch correctness and latency, then cut writes over and keep SQL Server read-only until confidence is earned.
- Decommission the SQL Server database and remove the connection strings and firewall paths that pointed at it.
Containerisation
Feasible after replatformingAppropriate, but the .NET Framework runtime has to go first; container work rides along with the replatform rather than preceding it.
- .NET Framework only runs on Windows; practical (Linux) containers need modern .NET
- Replatform to modern .NET first (see the recommended actions). Containerising then becomes routine.
- Add a Dockerfile and make the app read all configuration from environment variables and the secrets manager, never from machine-local files.
- Log to stdout and expose a health check endpoint so ECS can supervise it.
- Adopt the shared ci.yml pipeline template with the container parameters (awsRegion, containerAfterBuild, ecsTerraformRepo), which is exactly how the estate's existing AWS services deploy.
- Define the service in the Terraform repo, deploy to a non-production environment, then shift traffic and disarm the deployment-group release pipeline.
Recommended actions
Replatform phenix-sales-agent-markup to modern .NET
Runs on .NET Framework 4.8.1, .NET Framework 4.6.2, out of mainstream support. Blocked until stage 2 cuts: application-framework. Shares sqlserver:Phenix, so batch it with its database group (stage 4).
Impact: Reduces the end-of-life runtime count
proposedAssessment notes
phenix-sales-agent-markup
Purpose
A very small Phenix child site with one HomeController that lets the logged-in sales agent read and save their default accommodation markup percentage. Reads/writes via the UserDefaultMarkup_Search/save stored procedures and invalidates the specialised TC.Cache.Specialised.UserDefaultMarkup cache.
Tech stack
Three-project solution: an ASP.NET MVC 5 web app on .NET Framework 4.8.1 (modern C# with primary constructors, Autofac DI, Web.config transforms per environment) plus SDK-style Domain and DataAccess class libraries targeting net462. Data access is raw SqlCommand stored-procedure calls through the ConnectionBroker default connection.
Deployment
One release pipeline phenix-sales-agent-markup (release_count 1) from the matching build pipeline, defined by build-salesagentmarkup-ui.yml in the repo using shared azure-pipelines-templates from the InternalOSS project. Deployed under the Phenix IIS site.
Dependencies
Internal packages: TC.ConnectionBroker (Redis, Wcf, Autofac extensions), TC.Cache stack with the UserDefaultMarkup specialised cacher, TC.Phenix.ApplicationFramework, TC.Phenix.User/User.Authentication, TC.ContactCentre.ServiceClient, TC.UserAccount.ServiceClient, TC.Exceptions. No third-party services.
Data stores
No owned database — stored procedures run against the ConnectionBroker default database (the shared Phenix database). Redis is the configured cache storage (CacheStorage=redis).
Integration points
Server-rendered MVC page for authenticated Phenix users; outbound WCF/SOAP via the contact-centre and user-account service clients used by the shared authentication stack.
Code health
One MSTest project covering the single controller. Clean configs with no connection strings or secrets (service discovery via ConnectionBroker). No README at all. Last commit 2026-01-13 — low but recent activity, consistent with a feature-complete micro-site.
Modernisation risks
Tiny surface area but on ASP.NET MVC/.NET Framework 4.8.1, coupled to the shared Phenix database and the Phenix forms-auth session. An obvious candidate to fold into a modern Phenix UI or API rather than modernise standalone; risk of doing nothing is low, hence medium priority.