job-update-trading-history
Scheduled console job that recalculates and updates trading history for businesses, calling booking, teams, contact and user-account services and sending notification emails via the mail template service.
Health score
0 to 100 across seven weighted factors; nothing is hidden. Green is 75 and above, amber 50 to 74, red below 50. How scoring works.
Facts
| Languages | csharp |
| Frameworks | TC.MaintainanceTools.SimpleJobs 6.0.2, SimpleInjector 5.5 |
| Runtimes | .NET 8 |
| Tests / CI | none / CI in place |
| Last commit | 2025-06-27 |
| Owner | Owner unknown (mapping to be curated) |
| Domain | Platform services (system generated; curate in repo-owners.json to override) |
| Product area | Phenix |
| Hosted | On-prem Deployed to our own machines
|
| Releases | 1 release pipeline(s): \finance\jobs\job-update-trading-history CI |
| Integration | rest, wcf |
| Source | Open in Azure DevOps |
Dependencies in context
Entanglement
kernel Bound into the core by 2 mechanism(s).
- Pinning dependency: mailtemplate-service
- Speaks WCF (client)
Detaches when its pinning dependencies are cut or multi-targeted (mailtemplate-service); and when its WCF surface gains a modern interface or its WCF calls move to one.
Depends on / used by
Migration playbooks
Generated from this repo's assessment data: what is feasible, what blocks it, and the steps in order. Ratings: green means actionable now, amber means sequence other work first, red means blocked, grey means not applicable.
ZDD adoption
Needs workFeasible through the Workflow Engine's rolling drain, but real preparation is needed: dual-version discipline, better tests, or schema care before at-will release is sensible. No automated tests yet.
- Consumes WCF contract packages: never take a breaking client bump mid-feature, and treat obsolete warnings as migration debt
- Adopt the four-stage discipline from the ZDD engineering standard: pre-deployment compatibility, deployment, feature activation behind a flag, post-release cleanup.
- Raise automated test coverage first: ZDD trades the end-of-sprint manual gate for continuous automated confidence, so the tests are the entry ticket.
- Make every change dual-version safe: backwards-compatible APIs (new major version for breaking wire changes), expand and contract for any schema change, and consumers tolerant of unknown fields.
- Wrap behaviour changes in feature flags so code deploys dark and release becomes a business decision, not a deployment event.
- Route deployments through the Workflow Engine's automated drain, deploy, health-check, return cycle (the path proven by the first automated production run in mid-2026).
- Verify with area-scoped regression rather than the whole-platform cycle, and watch error rates after rollout with automated rollback on alert.
SQL Server exit
Not applicableNo SQL Server dependency is recorded for this repo. Nothing to migrate.
Containerisation
Ready to containeriseModern runtime, no hosted legacy transport: this service can follow the estate's proven container path (Dockerfile, shared pipeline template, ECS via Terraform).
- Add a Dockerfile and make the app read all configuration from environment variables and the secrets manager, never from machine-local files.
- Log to stdout and expose a health check endpoint so ECS can supervise it.
- Adopt the shared ci.yml pipeline template with the container parameters (awsRegion, containerAfterBuild, ecsTerraformRepo), which is exactly how the estate's existing AWS services deploy.
- Define the service in the Terraform repo, deploy to a non-production environment, then shift traffic and disarm the deployment-group release pipeline.
Recommended actions
No specific actions for this repo. It either needs only normal maintenance, or its work is covered by an estate-level action. See the full programme.
Assessment notes
job-update-trading-history
Purpose
Console job (UpdateTradingHistoryJob) built on the internal TC.MaintainanceTools.SimpleJobs framework. It iterates over businesses, updates their trading history via the Phenix booking service facade, resolves team membership and contact details, and sends templated emails through the mail template service.
Tech stack
Single C# console project targeting .NET 8, wired with SimpleInjector. Uses the internal TC.ConnectionBroker packages for service discovery of HTTP and WCF endpoints, plus TC service-client NuGet packages (TC.Phenix.Services.Client, TC.Mail.Template.ServiceClient, TC.UserAccount.ServiceClient, TC.Teams.Contracts).
Deployment
Included as a prod application with 1 release. One build pipeline (job-update-trading-history) and one release pipeline (\finance\jobs\job-update-trading-history CI). CI is YAML-based (build.yaml) using the shared InternalOSS/azure-pipelines-templates repo with .NET SDK 8.x.
Dependencies
Internal: Teams API (teams-service), Contact API (phenix-contact-api), mail template service (mailtemplate-service), user account service (backoffice-useraccount-service), connection broker (tc-connectionbroker), and the Phenix booking WCF service. External: New Relic for APM (app name configured in appsettings.json).
Data stores
No direct data store access; all persistence is via downstream services.
Integration points
REST over HttpClient (Teams and Contact APIs via brokered endpoints) and WCF (TC.Phenix.Services.Client.BookingServiceReference, TC.ConnectionBroker.Wcf).
Code health
No test projects in the repo. YAML CI pipeline present. Last commit 2025-06-27; small, focused codebase (one project, a handful of classes).
Modernisation risks
Low risk: already on .NET 8 with YAML CI. Main concerns are the absence of automated tests and the residual WCF dependency on the legacy Phenix booking service, which ties the job to older SOAP-era infrastructure.